Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17546#discussion_r110090087
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
---
@@ -150,12 +148,15 @@ object JoinReorderDP extends PredicateHelper with
Logging {
case (item, id) => Set(id) -> JoinPlan(Set(id), item, Set(), Cost(0,
0))
}.toMap)
+ // Build filters from the join graph to be used by the search
algorithm.
+ val filters = JoinReorderDPFilters(conf).buildJoinGraphInfo(items,
conditions, itemIndex)
+
// Build plans for next levels until the last level has only one plan.
This plan contains
// all items that can be joined, so there's no need to continue.
val topOutputSet = AttributeSet(output)
- while (foundPlans.size < items.length && foundPlans.last.size > 1) {
+ while (foundPlans.size < items.length) {
--- End diff --
yea we should remove this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
