Github user ioana-delaney commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17546#discussion_r110318621
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -736,6 +736,12 @@ object SQLConf {
           .checkValue(weight => weight >= 0 && weight <= 1, "The weight value 
must be in [0, 1].")
           .createWithDefault(0.7)
     
    +  val JOIN_REORDER_DP_STAR_FILTER =
    +    buildConf("spark.sql.cbo.joinReorder.dp.star.filter")
    +      .doc("Applies star-join filter heuristics to cost based join 
enumeration.")
    +      .booleanConf
    +      .createWithDefault(false)
    --- End diff --
    
    @gatorsmile Regardless of the default value, I still want to control the 
filters with their own knobs. The filters are applied on top of the join 
enumeration. They need to have their own control.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to