Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17562#discussion_r110335441
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala
 ---
    @@ -134,15 +134,20 @@ class FilterPushdownSuite extends PlanTest {
         comparePlans(optimized, correctAnswer)
       }
     
    -  test("nondeterministic: can't push down filter with nondeterministic 
condition through project") {
    --- End diff --
    
    This test was wrong, actually we can push down nondeterministic filter 
through project, as long as the project list is all deterministic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to