Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17556#discussion_r110375204
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala ---
@@ -1009,10 +1009,24 @@ private[spark] object RandomForest extends Logging {
// sort distinct values
val valueCounts = valueCountMap.toSeq.sortBy(_._1).toArray
+ def weightedMean(pre: (Double, Int), cru: (Double, Int)): Double = {
+ val (preValue, preCount) = pre
+ val (curValue, curCount) = cru
+ (preValue * preCount + curValue * curCount) / (preCount + curCount)
--- End diff --
I'm probably over-thinking this, but do we have a possible overflow issue
in the denominator? like if both are near `Int.MaxValue`. One could be
converted `.toDouble` just to make sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
