Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/17149#discussion_r110420176
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -285,7 +285,7 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
// compatible format, which means the data source is file-based
and must have a `path`.
require(table.storage.locationUri.isDefined,
"External file-based data source table must have a `path` entry
in storage properties.")
- Some(new Path(table.location).toUri.toString)
--- End diff --
aah, paths, especially on windows make me weep. Note also lots of fun
related to encoded secrets in s3n/s3a/s3 urls (HADOOP-3733 and the associated
regression HADOOP-14114)
Because of those patches, and the fact that if you want to embed a / in an
S3A URI you *must* escape it, I don't know what to say here.
If you can come up with a simple set of questions to ask someone who
doesn't know this code but could understand Path's logic, I could pass them on
to some people I think may know the answer. Maybe @Cnauroth might have some
insight on what windows gets up to
BTW, Path in Hadoop 2.9 is Serializable. you can pass them down to closures
working on RDDs, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
