Github user yssharma commented on the issue:

    https://github.com/apache/spark/pull/17467
  
    @brkyvz - thanks for taking time to review the patch. appreciate it.
    Implemented all your suggestions. Now passing a new map for the kinesis 
configs and added mechanism to use the builder for the configs.
    
    As for the spark context, I wanted to use the sparkcontext available in 
`KinesisBackedBlockRDD` directly as well (instead of creating a new config 
map), but the sc in `KinesisBackedBlockRDD`
    is not available, and trying to use it there causes serialization errors. 
Passing a different config map looked like the only simple solution to access 
the kineses configs.
    
    The patch now doesnot use the `sc` at all and expects a kinesisConf to be 
passed to the `KinesisInputDStream` builder directly.
    
    Let me know your thoughts. Thanks again for the review comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to