Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110587691
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -401,8 +401,9 @@ abstract class QueryPlan[PlanType <:
QueryPlan[PlanType]] extends TreeNode[PlanT
* do not use `BindReferences` here as the plan may take the expression
as a parameter with type
* `Attribute`, and replace it with `BoundReference` will cause error.
*/
- protected def normalizeExprId[T <: Expression](e: T, input: AttributeSeq
= allAttributes): T = {
+ def normalizeExprId[T <: Expression](e: T, input: AttributeSeq =
allAttributes): T = {
--- End diff --
oh, seems we can move this method to `object QueryPlan`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
