GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/17604

    [SPARK-20289][SQL] Use StaticInvoke to box primitive types

    ## What changes were proposed in this pull request?
    Dataset typed API currently uses NewInstance to box primitive types (i.e. 
calling the constructor). Instead, it'd be slightly more idiomatic in Java to 
use PrimitiveType.valueOf, which can be invoked using StaticInvoke expression.
    
    ## How was this patch tested?
    The change should be covered by existing tests for Dataset encoders.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark SPARK-20289

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/17604.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #17604
    
----
commit 8cbc617ee528ab92a755995a03b9ebefc2eb03a4
Author: Reynold Xin <r...@databricks.com>
Date:   2017-04-11T08:21:38Z

    [SPARK-20289][SQL] Use StaticInvoke to box primitive types

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to