Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16774#discussion_r110983267
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -121,6 +121,33 @@ class CrossValidatorSuite
}
}
+ test("cross validation with parallel evaluation") {
+ val lr = new LogisticRegression
+ val lrParamMaps = new ParamGridBuilder()
+ .addGrid(lr.regParam, Array(0.001, 1000.0))
+ .addGrid(lr.maxIter, Array(0, 3))
+ .build()
+ val eval = new BinaryClassificationEvaluator
+ val cv = new CrossValidator()
+ .setEstimator(lr)
+ .setEstimatorParamMaps(lrParamMaps)
+ .setEvaluator(eval)
+ .setNumFolds(2)
+ .setNumParallelEval(1)
+ val cvSerialModel = cv.fit(dataset)
+ cv.setNumParallelEval(2)
+ val cvParallelModel = cv.fit(dataset)
+
+ val serialMetrics = cvSerialModel.avgMetrics.sorted
+ val parallelMetrics = cvParallelModel.avgMetrics.sorted
+ assert(serialMetrics === parallelMetrics)
+
+ val parentSerial =
cvSerialModel.bestModel.parent.asInstanceOf[LogisticRegression]
+ val parentParallel =
cvParallelModel.bestModel.parent.asInstanceOf[LogisticRegression]
+ assert(parentSerial.getRegParam === parentParallel.getRegParam)
--- End diff --
It should probably be done in the test that already runs `checkCopy` on
line 62 (at least until we cleanup these basic checks). I'll take a look at
that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
