Github user ioana-delaney commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17546#discussion_r110984951
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
 ---
    @@ -54,8 +54,6 @@ case class CostBasedJoinReorder(conf: SQLConf) extends 
Rule[LogicalPlan] with Pr
     
       private def reorder(plan: LogicalPlan, output: Seq[Attribute]): 
LogicalPlan = {
         val (items, conditions) = extractInnerJoins(plan)
    -    // TODO: Compute the set of star-joins and use them in the join 
enumeration
    -    // algorithm to prune un-optimal plan choices.
    --- End diff --
    
    @cloud-fan That’s correct. If CBO is enabled, it will do the final 
planning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to