[GitHub] spark pull request #17477: [SPARK-18692][BUILD][DOCS] Test Java 8 unidoc bui...

Wed, 12 Apr 2017 01:11:30 -0700 

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17477#discussion_r111087424
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEndpoint.scala ---
    @@ -35,7 +35,7 @@ private[spark] trait RpcEnvFactory {
      *
      * The life-cycle of an endpoint is:
      *
    - * constructor -> onStart -> receive* -> onStop
    + * {@code constructor -> onStart -> receive* -> onStop}
    --- End diff --
    
    After this, it produces the documentation as below (manually tested)
    
    **Scaladoc**
    
    ![2017-04-12 5 08 
09](https://cloud.githubusercontent.com/assets/6477701/24947668/a9cabad0-1fa2-11e7-84a9-d08ba0eba621.png)
    
    **Javadoc**
    
    ![2017-04-12 5 07 
58](https://cloud.githubusercontent.com/assets/6477701/24947667/a9c8628a-1fa2-11e7-9e9c-40b51daa43f0.png)
    
    This also seems not exposed to API documentation anyway.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to