Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r111225202
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -720,7 +717,24 @@ object SparkSubmit extends CommandLineUtils {
printWarning("Subclasses of scala.App may not work correctly. Use a
main() method instead.")
}
- val mainMethod = mainClass.getMethod("main", new
Array[String](0).getClass)
+ val sparkAppMainMethodArr = mainClass.getMethods().filter(_.getName ==
"sparkMain")
--- End diff --
Hmmm... instead of this, how about:
```
val sparkAppMain = mainClass.getMethods().find(_.getName == "sparkMain")
```
Then you have an `Option[Method]` which should make the code below a little
cleaner. At the very least you won't need the `isSparkApp` variable nor the
array dereference in L734. L733 would just become `mainMethod =
sparkAppMain.getOrElse(...)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
