Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2391#discussion_r17816266
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -214,6 +245,27 @@ private[history] class FsHistoryProvider(conf:
SparkConf) extends ApplicationHis
}
}
+ /**
+ * Deleting apps if setting cleaner.
+ */
+ private def cleanLogs() = {
+ lastLogCleanTimeMs = System.currentTimeMillis()
+ logDebug("Cleaning logs. Time is now %d.".format(lastLogCleanTimeMs))
+ try {
+ val logStatus = fs.listStatus(new Path(resolvedLogDir))
+ val logDirs = if (logStatus != null) logStatus.filter(_.isDir).toSeq
else Seq[FileStatus]()
+ val maxAge = conf.getLong("spark.history.fs.maxAge", 604800) * 1000
+ logDirs.foreach{
+ case dir: FileStatus =>
+ if(System.currentTimeMillis() - getModificationTime(dir) >
maxAge) {
+ fs.delete(dir.getPath, true)
--- End diff --
I wonder if it would be better to try each delete separately; if someone
writes a directory with wrong permissions to the log dir, they may cause the
cleaner thread to never clean up anything.
(That would be better if there were a more descriptive exception for those
errors, but I think all `FileSystem` will throw are `IOException`s and
`InterruptedException`s.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
