Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/17342#discussion_r111365777
--- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
@@ -1021,4 +1021,19 @@ class UtilsSuite extends SparkFunSuite with
ResetSystemProperties with Logging {
secretKeys.foreach { key => assert(redactedConf(key) ===
Utils.REDACTION_REPLACEMENT_TEXT) }
assert(redactedConf("spark.regular.property") === "not_a_secret")
}
+
+ test("SparkUrlStreamHandlerFactory") {
+ URL.setURLStreamHandlerFactory(new SparkUrlStreamHandlerFactory())
+
+ // if 'hdfs' is not supported, MalformedURLException will be thrown
+ new URL("hdfs://docs.oracle.com/test.jar")
--- End diff --
you should check to see what happens when you run this test on a machine
with no network connection. Everyone hates tests that fail when they rely on
DNS working (or, in some cases, DNS not resolving an example.org domain)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
