Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/17630#discussion_r111535093
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/Statistics.scala
---
@@ -184,6 +196,26 @@ object ColumnStat extends Logging {
}
/**
+ * Converts from string representation of external data type to the
corresponding Catalyst data
+ * type.
+ */
+ private def fromExternalString(s: String, name: String, dataType:
DataType): Any = {
+ dataType match {
+ case BooleanType => s.toBoolean
+ case _: IntegralType => s.toLong
+ case DateType =>
DateTimeUtils.fromJavaDate(java.sql.Date.valueOf(s)).toLong
--- End diff --
hm.. I think it's better to keep min/max value in ColumnStat just the same
as internal type, i.e. don't cast short/int to long. This causes less
confusion. Besides, we'll use decimal to unify their comparison and computation
logics anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
