GitHub user sujith71955 opened a pull request:
https://github.com/apache/spark/pull/17649
[SPARK-20023][SQL][follow up] Output table comment for DESC FORMATTED after
adding/modifying table comment using Alter TableSetPropertiesCommand
### What changes were proposed in this pull request?
This PR is a follow up PR to **JIRA issue 20023** where table comment was
not displayed in describe formatted command after user creates a table with
table comment.But still was issue when user alter the table properties and
adds/updates table comment. table comment which is directly part of
CatalogTable instance where not getting updated and old table comment was
shown, to handle this issue while updating the table properties map with
newly added/modified properties in CatalogTable
instance also update the comment parameter with newly added/modified
comment as part of **AlterTableSetPropertiesCommand** which is also now exist
in CatalogTable instance level not only in tableproperties map of CatalogTable
instance.
### How was this patch tested?
Added test cases as part of **SQLQueryTestSuite** for verifying table
comment using desc formatted table query after adding or modifying table
comment as part of **AlterTableSetPropertiesCommand**.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sujith71955/spark alter_table_comment
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17649.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17649
----
commit 1db31031d86f2d674242bba567a7c9101577f46a
Author: sujith71955 <[email protected]>
Date: 2017-04-15T17:47:50Z
[SPARK-20023] [SQL] [follow up] Output table comment for DESC FORMATTED
after adding/modifying table comment using Alter TableSetPropertiesCommand
### What changes were proposed in this pull request?
This PR is a follow up PR to JIRA issue 20023 where table comment was not
displayed in describe formatted command after user creates a table with table
comment.
But still was issue when user alter the table properties and adds/updates
table comment. table comment which is directly part of CatalogTable instance
where not getting updated and
old table comment was shown, to handle this issue while updating the table
properties map with newly added/modified properties in CatalogTable instance
also
update the comment parameter with newly added/modified comment as part of
AlterTableSetPropertiesCommand which is also now exist in CatalogTable
instance level not only in table
properties map of CatalogTable instance.
### How was this patch tested?
Added test cases as part of SQLQueryTestSuite for verifying table comment
using desc formatted table query after adding or modifying table comment as
part of AlterTableSetPropertiesCommand.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
