GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/17661
[SPARK-20349] [SQL] [REVERT-Branch2.1] ListFunctions returns duplicate
functions after using persistent functions
Revert the changes of https://github.com/apache/spark/pull/17646 made in
Branch 2.1, because it breaks the build. It needs the parser interface, but
SessionCatalog in branch 2.1 does not have it.
### What changes were proposed in this pull request?
The session catalog caches some persistent functions in the
`FunctionRegistry`, so there can be duplicates. Our Catalog API `listFunctions`
does not handle it.
It would be better if `SessionCatalog` API can de-duplciate the records,
instead of doing it by each API caller. In `FunctionRegistry`, our functions
are identified by the unquoted string. Thus, this PR is try to parse it using
our parser interface and then de-duplicate the names.
### How was this patch tested?
Added test cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark compilationFix17646
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17661.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17661
----
commit 64c252e9bda3ddbab61fc53cf0c79ea94211fca2
Author: Xiao Li <[email protected]>
Date: 2017-04-17T20:21:53Z
revert
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
