Github user jerryshao commented on the issue:

    https://github.com/apache/spark/pull/17582
  
    @tgravescs , with the changes of history UI, REST API and web UI are now 
mixed. The base URL to list all the apps is through REST API.
    
    The key problem here is that in History Server we could have configured two 
ACLs (spark.acls.enable 
[here](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala#L299)
 and spark.history.ui.acls.enable 
[here](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala#L248)),
 this two ACLs checks different URLs, for example:
    
    ```
    /api/v1/applications
    /api/v1/applications/<app-id>
    /api/v1/applications/<app-id>/logs
    ```
    
    are controlled by `spark.acls.enable`. And web UI will use this API to list 
and show apps on the UI. If this is enabled, then only SHS owner, admin/view 
user groups could see the apps list on the SHS's base web UI.
    
    And all the other URLs (web UI and REST API) for application details are 
controlled by `spark.history.ui.acls.enable`.
    
    If we configured differently for this two ACLs, then we will get some 
unexpected behaviors.
    
    So what I here fixed is to unify the ACL and offer the right behavior. 
    
    >No, there shouldn't be sensitive information there and many times a user 
is looking for a job run by say a headless user or other user. I guess you 
could filter only the jobs that user has acls to but that makes it more 
complicated. Do you have a concrete reason it should be protected? Note that 
this follow how other Hadoop UI's work.
    
    We worked with customers and they wish to filter and list apps based on the 
login users. But I don't have strong opinion it. I could change to what you 
suggested.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to