Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r111943766
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -836,17 +836,30 @@ class Analyzer(
Generate(newG.asInstanceOf[Generator], join, outer, qualifier,
output, child)
}
+ // If grouping keys have unresolved expressions, we need to replace
them with resolved one
+ // in SELECT clauses.
+ case agg @ Aggregate(groups, aggs, child)
+ if conf.groupByAliasesEnabled && child.resolved &&
aggs.forall(_.resolved) &&
+ groups.exists(!_.resolved) =>
+ agg.copy(groupingExpressions = groups.map {
+ case u: UnresolvedAttribute =>
+ aggs.find(ne => resolver(ne.name, u.name)).map {
+ case Alias(e, _) => e
+ case e => e
+ }.getOrElse(u)
+ case e => e
+ })
+
// Skips plan which contains deserializer expressions, as they
should be resolved by another
// rule: ResolveDeserializer.
case plan if containsDeserializer(plan.expressions) => plan
case q: LogicalPlan =>
logTrace(s"Attempting to resolve ${q.simpleString}")
- q transformExpressionsUp {
+ q.transformExpressionsUp {
case u @ UnresolvedAttribute(nameParts) =>
- // Leave unchanged if resolution fails. Hopefully will be
resolved next round.
- val result =
- withPosition(u) { q.resolveChildren(nameParts,
resolver).getOrElse(u) }
+ // Leave unchanged if resolution fails. Hopefully will be
resolved next round.
+ val result = withPosition(u) { q.resolveChildren(nameParts,
resolver).getOrElse(u) }
--- End diff --
let's have a separated rule
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
