Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r111955189
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -472,11 +472,11 @@ identifierComment
;
relationPrimary
- : tableIdentifier sample? (AS? strictIdentifier)?
#tableName
- | '(' queryNoWith ')' sample? (AS? strictIdentifier)?
#aliasedQuery
- | '(' relation ')' sample? (AS? strictIdentifier)?
#aliasedRelation
- | inlineTable
#inlineTableDefault2
- | identifier '(' (expression (',' expression)*)? ')'
#tableValuedFunction
+ : tableIdentifier sample? (AS? strictIdentifier)?
#tableName
+ | '(' queryNoWith ')' sample? (AS? strictIdentifier)?
#aliasedQuery
+ | '(' relation ')' sample? (AS? strictIdentifier)?
#aliasedRelation
+ | inlineTable
#inlineTableDefault2
+ | identifier '(' (expression (',' expression)*)? ')' (AS? identifier
identifierList?)? #tableValuedFunction
--- End diff --
oh, it seems I misunderstood what you pointed out. You meant should we need
to support a query like `SELECT * FROM [[tvf]] AS t(a, b, ...)` in this pr?
Yea, I know we currently support `range` only as a table value function though,
I also think it'd be better to put a more general rule in this file. So +1 for
keeping this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
