Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/17191#discussion_r112114553
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2349,7 +2350,26 @@ class Analyzer(
}
/**
- * Replace [[TimeZoneAwareExpression]] without timezone id by its copy
with session local
+ * Replace unresolved expressions in grouping keys with resolved ones in
SELECT clauses.
+ */
+ object ResolveAggAliasInGroupBy extends Rule[LogicalPlan] {
+
+ override def apply(plan: LogicalPlan): LogicalPlan =
plan.resolveOperators {
+ case agg @ Aggregate(groups, aggs, child)
+ if conf.groupByAliasesEnabled && child.resolved &&
groups.exists(!_.resolved) =>
--- End diff --
ISTM all the expressions in SELECT clauses are expected be resolved in
Resolution batch. So, I removed the condition from the latest version of this
pr. Actually, I couldn't find error test cases without the condition. Any idea
for that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
