Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/17416
  
    Thanks @BryanCutler ! yes that's working better. I can run, for example, 
`./bin/spark-shell --packages 
edu.stanford.nlp:stanford-corenlp:jar:models:3.4.1` and I can see that it's now 
on the classpath, because I can load its files with `getResourceAsStream`.
    
    There's a smaller corner case that doesn't quite seem to work, and that is 
adding both a classified and unclassified version of the same artifact, as in 
`./bin/spark-shell --packages 
edu.stanford.nlp:stanford-corenlp:jar:models:3.4.1,edu.stanford.nlp:stanford-corenlp:3.4.1`
 The classifier version isn't loaded in this case.
    
    Unless you see a clean fix for that too (I don't yet, still looking), I'm 
still inclined to merge this as it makes a significant set of artifacts now 
addressable, and loading via `spark-shell` is a bit best-effort anyway (this 
problem doesn't exist for a packaged app).
    
    I need to add a test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to