Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17674#discussion_r112250519
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -942,6 +942,14 @@ setGeneric("countDistinct", function(x, ...) { 
standardGeneric("countDistinct")
     #' @export
     setGeneric("crc32", function(x) { standardGeneric("crc32") })
     
    +#' @rdname create_array
    --- End diff --
    
    actually you are right - I saw `###################### Column Methods 
##########################` and thought that's the place but you are right, we 
already have them in both places.
    
    I'm fine with what you have


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to