Github user ptkool commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17650#discussion_r112309456
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
 ---
    @@ -160,4 +166,12 @@ class BooleanSimplificationSuite extends PlanTest with 
PredicateHelper {
           testRelation.where('a > 2 || ('b > 3 && 'b < 5)))
         comparePlans(actual, expected)
       }
    +
    +  test("Complementation Laws") {
    --- End diff --
    
    Is this really required for this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to