Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17695#discussion_r112380848
  
    --- Diff: docs/configuration.md ---
    @@ -2248,8 +2248,8 @@ should be included on Spark's classpath:
     * `hdfs-site.xml`, which provides default behaviors for the HDFS client.
     * `core-site.xml`, which sets the default filesystem name.
     
    -The location of these configuration files varies across CDH and HDP 
versions, but
    -a common location is inside of `/etc/hadoop/conf`. Some tools, such as 
Cloudera Manager, create
    +The location of these configuration files varies across hadoop versions, 
but
    +a common location is inside of `/etc/hadoop/conf`. Some tools create
    --- End diff --
    
    This also won't matter either way, but is an example of an instance where 
naming a specific product is helpful information for users. There's no policy 
against this. But, it can be removed, sure, it's trivial either way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to