Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17672#discussion_r112504896
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3652,3 +3652,43 @@ setMethod("posexplode",
                 jc <- callJStatic("org.apache.spark.sql.functions", 
"posexplode", x@jc)
                 column(jc)
               })
    +
    +#' collect_list
    +#'
    +#' Creates a list of objects with duplicates.
    +#'
    +#' @param x Column to compute on
    +#'
    +#' @rdname collect_list
    +#' @name collect_list
    +#' @family agg_func
    --- End diff --
    
    we really should - it's a long standing concern that something like 
    ```
    @examples \dontrun{collect_list(df$x)}
    ```
    is not useful at all. At least we should include how this goes into a 
select statement, and in some cases what the output looks like. However, with 
the number of sql functions we have it's a bit of ongoing work to improve this 
and we definitely can use more help on that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to