Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17708#discussion_r112509679
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
 ---
    @@ -537,5 +537,10 @@ class PlanParserSuite extends PlanTest {
         comparePlans(
           parsePlan("SELECT /*+ MAPJOIN(t) */ a from t where true group by a 
order by a"),
           Hint("MAPJOIN", Seq("t"), 
table("t").where(Literal(true)).groupBy('a)('a)).orderBy('a.asc))
    +
    +    comparePlans(
    +      parsePlan("SELECT a FROM (SELECT /*+ NO_COLLAPSE */ * FROM t) t1"),
    +      SubqueryAlias("t1", Hint("NO_COLLAPSE", Seq.empty, 
table("t").select(star())))
    --- End diff --
    
    What are you testing here that is not covered by the other cases?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to