Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2482#discussion_r17827908
--- Diff: core/src/main/scala/org/apache/spark/RunAsyncResult.scala ---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark
+
+import scala.concurrent._
+import scala.concurrent.duration.Duration
+import scala.util.Try
+
+
+/**
+ * This is an extension of the Scala Future interface to support
cancellation.
+ */
+class RunAsyncResult[T](jobGroupId: String,
+ jobGroupDescription: String,
+ sc: SparkContext,
+ func: => T) extends Future[T] {
+
+ // Pointer to the thread that is executing the action; it is set when
the action is run.
+ @volatile private var thread: Thread = _
+
+ // A promise used to signal the future.
+ private val p = promise[T]()
+
+ /**
+ * Cancel this Future and any Spark jobs launched from it. The
cancellation of Spark jobs is
+ * performed asynchronously.
+ */
+ def cancel(): Unit = this.synchronized {
+ if (thread != null) {
+ thread.interrupt()
--- End diff --
note that this is not a reliable (actually very unreliable) way of
cancelling a thread.
this only stops the thread if it is waiting on io or sleeping. if the user
thread is actually executing stuff (or busy looping), this doesn't do anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
