Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/17706#discussion_r112745372
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -1204,6 +1207,9 @@ class LogisticRegressionSuite
-0.3180040, 0.9679074, -0.2252219, -0.4319914,
0.2452411, -0.6046524, 0.1050710, 0.1180180), isTransposed = true)
+ model1.coefficientMatrix.colIter.foreach(v => assert(v.toArray.sum ~==
0.0 absTol eps))
--- End diff --
Before we tested that the coefficients have zero mean using:
`assert(model1.coefficientMatrix.toArray.sum ~== 0.0 absTol eps)`
We should replace every instance of that test with this new one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
