Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17623#discussion_r112854488
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
 ---
    @@ -111,6 +111,11 @@ case class GetStructField(child: Expression, ordinal: 
Int, name: Option[String]
       override def dataType: DataType = childSchema(ordinal).dataType
       override def nullable: Boolean = child.nullable || 
childSchema(ordinal).nullable
     
    +  override def verboseString: String = {
    --- End diff --
    
    I don't think the `verboseString` here provides better string 
representation than `toString`, when will we call `verboseString`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to