Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/17752#discussion_r113080192
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaConsumer.scala
---
@@ -35,7 +35,7 @@ import org.apache.spark.sql.kafka010.KafkaSource._
* Underlying consumer is not threadsafe, so neither is this,
* but processing the same topicpartition and group id in multiple threads
is usually bad anyway.
*/
-private[kafka010] case class CachedKafkaConsumer private(
+private[kafka010] case class CachedKafkaConsumer(
--- End diff --
Isnt it cleaner to create a new method `create` in object
CachedKafkaConsumer which returns a new CachedKafkaConsumer without putting it
in the map?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
