Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r113085844
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -725,9 +722,15 @@ object SparkSubmit extends CommandLineUtils {
printWarning("Subclasses of scala.App may not work correctly. Use a
main() method instead.")
}
- val mainMethod = mainClass.getMethod("main", new
Array[String](0).getClass)
- if (!Modifier.isStatic(mainMethod.getModifiers)) {
- throw new IllegalStateException("The main method in the given main
class must be static")
+ val sparkAppMainMethod = mainClass.getMethods().find(_.getName ==
"sparkMain")
+ val childSparkConf = sysProps.filter{ p => p._1.startsWith("spark.")
}.toMap
--- End diff --
nit: again, please address the feedback that is given. I've lost count of
how many times I've pointed out that there's a missing space between `filter`
and `{`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
