Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2311#discussion_r17863181
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -119,13 +126,7 @@ private[spark] class ApplicationMaster(args:
ApplicationMasterArguments,
} else {
runExecutorLauncher(securityMgr)
}
-
- if (finalStatus != FinalApplicationStatus.UNDEFINED) {
- finish(finalStatus)
- 0
- } else {
- 1
- }
+ exitCode
--- End diff --
Feels like with your changes there's a possibility that `finish()` might
never be called. Might be better to add a call to that method here before
returning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
