Github user facaiy commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17503#discussion_r113360409
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala 
---
    @@ -61,6 +61,8 @@ import org.apache.spark.mllib.tree.impurity.{Entropy, 
Gini, Impurity, Variance}
      * @param subsamplingRate Fraction of the training data used for learning 
decision tree.
      * @param useNodeIdCache If this is true, instead of passing trees to 
executors, the algorithm will
      *                       maintain a separate RDD of node Id cache for each 
row.
    + * @param canMergeChildren Merge pairs of leaf nodes of the same parent 
which
    --- End diff --
    
    A new parameter is added in Strategy class, which fails Mima tests. How to 
deal with it?
    
    ```bash
    [error]  * synthetic method <init>$default$13()Int in object 
org.apache.spark.mllib.tree.configuration.Strategy has a different result type 
in current version, where it is Boolean rather than Int
    ```
    [see failed 
logs](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3675/consoleFull)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to