Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17649#discussion_r113373050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -295,7 +295,9 @@ class InMemoryCatalog(
assert(tableDefinition.identifier.database.isDefined)
val db = tableDefinition.identifier.database.get
requireTableExists(db, tableDefinition.identifier.table)
- catalog(db).tables(tableDefinition.identifier.table).table =
tableDefinition
+ val updatedProperties = tableDefinition.properties.filter(kv => kv._1
!= "comment")
+ val newTableDefinition = tableDefinition.copy(properties =
updatedProperties)
+ catalog(db).tables(tableDefinition.identifier.table).table =
newTableDefinition
--- End diff --
This only fixes the issue in InMemoryCatalog. We still have a hole in
HiveExternalCatalog.
Could you move the fixes to `AlterTableSetPropertiesCommand `?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
