Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17777#discussion_r113585819
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -165,6 +165,22 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
override def withTimeZone(timeZoneId: String): TimeZoneAwareExpression =
copy(timeZoneId = Option(timeZoneId))
+ // When this cast involves TimeZone, it's only resolved if the
timeZoneId is set;
+ // Otherwise behavior like Expression.resolved.
+ override lazy val resolved: Boolean =
+ childrenResolved && checkInputDataTypes().isSuccess &&
+ (!needsTimeZone() || timeZoneId.isDefined)
+
+ private[this] def needsTimeZone(): Boolean =
+ needsTimeZone(child.dataType, dataType) || needsTimeZone(dataType,
child.dataType)
+
+ // this matches the current implemented casting behaviors in the Cast
class
+ private[this] def needsTimeZone(t1: DataType, t2: DataType): Boolean =
(t1, t2) match {
+ case (StringType, TimestampType) => true
+ case (DateType, TimestampType) => true
--- End diff --
Could we just add two more cases here, instead of adding an extra function?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
