Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17715#discussion_r113650727
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -610,6 +639,38 @@ class LogisticRegressionSuite
assert(model2.coefficients ~= coefficientsR relTol 1E-3)
}
+ test("binary logistic regression with intercept without regularization
with bound") {
+ val upperBoundOfCoefficients = Matrices.dense(1, 4, Array(1.0, 0.0,
1.0, 0.0))
+ val upperBoundOfIntercept = Vectors.dense(1.0)
--- End diff --
Added corresponding test at ```test("logistic regression: illegal
params")```, I prefer to throw exception for this scenario.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
