Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17803#discussion_r113934080
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/streaming/GroupStateTimeout.java
 ---
    @@ -37,7 +37,9 @@
        * `map/flatMapGroupsWithState` by calling 
`GroupState.setTimeoutDuration()`. See documentation
        * on `GroupState` for more details.
        */
    -  public static GroupStateTimeout ProcessingTimeTimeout() { return 
ProcessingTimeTimeout$.MODULE$; }
    +  public static GroupStateTimeout processingTimeTimeout() {
    --- End diff --
    
    CC @tdas this especially would need your attention. The name of the method, 
being TitleCase instead of camelCase, generates a Java style error. It has a 
point. We can change it because these methods are only new in 2.2, but wanted 
to check that it is OK? or was it on purpose and needs to be suppressed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to