Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17801#discussion_r113937642
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2657,22 +2661,27 @@ object functions {
/**
* Converts time string in format yyyy-MM-dd HH:mm:ss to Unix timestamp
(in seconds),
- * using the default timezone and the default locale, return null if
fail.
+ * using the default timezone and the default locale.
+ * Returns `null` if fails.
+ *
* @group datetime_funcs
* @since 1.5.0
*/
def unix_timestamp(s: Column): Column = withExpr {
UnixTimestamp(s.expr, Literal("yyyy-MM-dd HH:mm:ss"))
}
+ // scalastyle:off line.size.limit
/**
- * Convert time string with given pattern
- * (see
[http://docs.oracle.com/javase/tutorial/i18n/format/simpleDateFormat.html])
- * to Unix time stamp (in seconds), return null if fail.
+ * Converts time string with given pattern to Unix timestamp (in
seconds).
+ * Returns `null` if fails.
+ *
+ * @see
[[http://docs.oracle.com/javase/tutorial/i18n/format/simpleDateFormat.html
Customizing Formats]]
--- End diff --
It looks the documentation generation for Javadoc 8 is being failed due to
`@see` with link -
```
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/sql/core/target/java/org/apache/spark/sql/functions.java:2996:
error: self-closing element not allowed
[error] * @see <a
href="http://docs.oracle.com/javase/tutorial/i18n/format/simpleDateFormat.html
Customizing Formats"/>
[error] ^
[error]
/home/jenkins/workspace/SparkPullRequestBuilder/sql/core/target/java/org/apache/spark/sql/functions.java:2996:
error: invalid uri:
"http://docs.oracle.com/javase/tutorial/i18n/format/simpleDateFormat.html
Customizing Formats"
[error] * @see <a
href="http://docs.oracle.com/javase/tutorial/i18n/format/simpleDateFormat.html
Customizing Formats"/>
[error]
^
```
Probably, we should wrap it `href` as I did before -
https://github.com/apache/spark/pull/16013 or find a way to make this link
properly (or just remove it).
The other errors seem spurious. Please refer my observation -
https://github.com/apache/spark/pull/17389#issuecomment-288438704
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
