Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17723#discussion_r114039586
  
    --- Diff: core/pom.xml ---
    @@ -357,6 +357,34 @@
           <groupId>org.apache.commons</groupId>
           <artifactId>commons-crypto</artifactId>
         </dependency>
    +
    +    <!--
    +     Testing Hive reflection needs hive on the test classpath only.
    +     It doesn't need the spark hive modules, so the -Phive flag is not 
checked.
    +      -->
    +    <dependency>
    +      <groupId>${hive.group}</groupId>
    +      <artifactId>hive-exec</artifactId>
    +    </dependency>
    +    <dependency>
    +      <groupId>${hive.group}</groupId>
    +      <artifactId>hive-metastore</artifactId>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.apache.thrift</groupId>
    +      <artifactId>libthrift</artifactId>
    +      <scope>test</scope>
    +    </dependency>
    +    <dependency>
    +      <groupId>org.apache.thrift</groupId>
    +      <artifactId>libfb303</artifactId>
    +      <scope>test</scope>
    +    </dependency>
    +
    +    <dependency>
    +      <groupId>org.apache.hadoop</groupId>
    +      <artifactId>hadoop-yarn-api</artifactId>
    --- End diff --
    
    Core depends on `hadoop-client` which depends on YARN already. So the 
explicit dependency here isn't really needed.
    
    The distinction was useful when Spark supported Hadoop 1.x (no YARN), but 
right now, it's mostly theoretical - every Spark build has YARN classes, 
regardless of whether the YARN module is included.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to