Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17783#discussion_r114058191
  
    --- Diff: R/pkg/R/column.R ---
    @@ -67,8 +67,7 @@ operators <- list(
       "+" = "plus", "-" = "minus", "*" = "multiply", "/" = "divide", "%%" = 
"mod",
       "==" = "equalTo", ">" = "gt", "<" = "lt", "!=" = "notEqual", "<=" = 
"leq", ">=" = "geq",
       # we can not override `&&` and `||`, so use `&` and `|` instead
    -  "&" = "and", "|" = "or", #, "!" = "unary_$bang"
    -  "^" = "pow"
    +  "&" = "and", "|" = "or", "^" = "pow"
    --- End diff --
    
    actually, let me back track... it looks like `"!" = "unary_$bang"` has 
always been commented out. the `#, ` does that
    I agree we don't need to leave that comment here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to