Github user zero323 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17807#discussion_r114058688
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3803,3 +3803,89 @@ setMethod("repeat_string",
                 jc <- callJStatic("org.apache.spark.sql.functions", "repeat", 
x@jc, numToInt(n))
                 column(jc)
               })
    +
    +#' is_grouping
    +#'
    +#' Indicates whether a specified column in a GROUP BY list is aggregated 
or not,
    +#' returns 1 for aggregated or 0 for not aggregated in the result set.
    --- End diff --
    
    As far as I remember this is actually SQL:1999 standard. And has direct 
relation to binary encoding used for grouping id.
    
    Maybe `is_grouping` is not the most fortunate choice of name, but I don't 
have a better idea. Theoretically we can use just `grouping` and let users 
worry about disambiguation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to