Github user zero323 commented on the issue:
https://github.com/apache/spark/pull/17807
I thought about it before, but there are two or three problems:
- `base::grouping` has `...` signature so it is not possible without
changing behavior or adding nullary variant.
- It makes impossible to add `SparkR::grouping` which accepts
`characterOrColumn` (and this something that we should do to achieve consistent
API).
- Finally it won't work that well if we decide to use some form of NSE.
There can be some other problems I am not aware of.
In general I fully agree that we should avoid conflicts when possible, but
I am skeptical about dispatching hacks, which in some border cases could
actually brake user code.
There are some other options we can explore:
- Adding common prefix like `sql.some_name` - a bit to verbose for my taste.
- Using `_` suffix. This is fine but can be confusing for advanced user who
may expect standard vs. non standard evaluation.
I trust your judgment so if you think that generic option is the best I'll
go with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
