Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17825#discussion_r114366327
  
    --- Diff: R/pkg/R/column.R ---
    @@ -132,17 +132,24 @@ createMethods()
     
     #' alias
     #'
    -#' Set a new name for a column
    +#' Set a new name for an object. Equivalent to SQL "AS" keyword.
    --- End diff --
    
    right, this is Scala doc for Column.alias `Gives the column an alias` 
(which is not very concise)
    Dataset.alias `Returns a new Dataset with an alias set.`
    
    I think we need to say `Set a new name to return as a new object` or 
similar. Actually I think we should say "Column or SparkDataFrame" in place of 
"object" - what do you think?
    
    I think the `SQL "AS"` part but perhaps it will be more clear if lead with 
"for Column, ..."?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to