Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17346#discussion_r114395114
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSink.scala
 ---
    @@ -53,6 +53,29 @@ object FileStreamSink extends Logging {
           case _ => false
         }
       }
    +
    +  /**
    +   * Returns true if the path is the metadata dir or its ancestor is the 
metadata dir.
    +   * E.g.:
    +   *  - ancestorIsMetadataDirectory(/.../_spark_metadata) => true
    +   *  - ancestorIsMetadataDirectory(/.../_spark_metadata/0) => true
    +   *  - ancestorIsMetadataDirectory(/a/b/c) => false
    +   */
    +  def ancestorIsMetadataDirectory(path: Path): Boolean = {
    +    require(path.isAbsolute, s"$path is required to be absolute")
    --- End diff --
    
    I'm wondering if we can call `makeQualified` instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to