Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16989#discussion_r114696480
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java
---
@@ -100,7 +114,14 @@ public void onSuccess(ByteBuffer response) {
// Immediately request all chunks -- we expect that the total
size of the request is
// reasonable due to higher level chunking in
[[ShuffleBlockFetcherIterator]].
for (int i = 0; i < streamHandle.numChunks; i++) {
- client.fetchChunk(streamHandle.streamId, i, chunkCallback);
+ if (fetchToDisk) {
+ final File targetFile = new File(".",
--- End diff --
@cloud-fan
Yes, but `OneForOneBlockFetcher` is in `network-shuffle` package, I find it
hard to import `SparkEnv` from `core` package. Did I miss something?(I'm sorry
if this question is stupid.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
