GitHub user MLnick opened a pull request:
https://github.com/apache/spark/pull/17860
[SPARK-20596][ML][TEST] Consolidate and improve ALS recommendAll test cases
Existing test cases for `recommendForAllX` methods (added in
[SPARK-19535](https://issues.apache.org/jira/browse/SPARK-19535)) test `k < num
items` and `k = num items`. Technically we should also test that `k > num
items` returns the same results as `k = num items`.
## How was this patch tested?
Updated existing unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MLnick/spark SPARK-20596-als-rec-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17860.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17860
----
commit 21c0ac59e9fc82a2da4ba44de1b3f4c000b0fd94
Author: Nick Pentreath <[email protected]>
Date: 2017-05-04T08:51:46Z
Consolidate test cases and add k > num recommendables case
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
