Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/17644#discussion_r114811914
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -632,9 +632,51 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
val rawTable = getRawTable(db, table)
val withNewSchema = rawTable.copy(schema = schema)
verifyColumnNames(withNewSchema)
+
+ val newProperties = collection.mutable.Map[String, String]()
+ for ((property, value) <- withNewSchema.properties) {
+ newProperties.put(property, value)
+ }
+ for ((property, value) <- tableMetaToTableProps(withNewSchema)) {
+ newProperties.put(property, value)
+ }
+
+ // Since the table schema will be changed, check if the bucketing and
sort columns are still
--- End diff --
I have to do this because one of the unit tests was failing :
https://github.com/apache/spark/blob/703c42c398fefd3f7f60e1c503c4df50251f8dcf/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalogSuite.scala#L246
In that test case, the table has a bucketing and alter removes the
bucketing column. The way I interpret things: if the alter command is not
removing the bucketing / sorting columns, we should keep the original bucketing
spec. If any one of the bucketing / sorting columns are removed in alter, then
the bucketing spec needs to be reset to empty (else we might refer to dangling
columns).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
