Github user shubhamchopra commented on a diff in the pull request:
https://github.com/apache/spark/pull/17673#discussion_r115009247
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -36,7 +36,10 @@ import org.apache.spark.util.{Utils, VersionUtils}
* Params for [[Word2Vec]] and [[Word2VecModel]].
*/
private[feature] trait Word2VecBase extends Params
- with HasInputCol with HasOutputCol with HasMaxIter with HasStepSize with
HasSeed {
+ with HasInputCol with HasOutputCol with HasMaxIter with HasStepSize with
HasSeed with HasSolver {
+ // We currently support SkipGram with Hierarchical Softmax and
+ // Continuous Bag of Words with Negative Sampling
+ private val supportedModels = Array("sg-hs", "cbow-ns")
--- End diff --
Good catch. It is not used. Fixing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
