Github user actuaryzhang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17879#discussion_r115124754
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
    @@ -59,6 +59,28 @@ private[feature] trait StringIndexerBase extends Params 
with HasInputCol with Ha
       @Since("1.6.0")
       def getHandleInvalid: String = $(handleInvalid)
     
    +  /**
    +   * Param for how to order labels of string column. The first label after 
ordering is assigned
    +   * an index of 0.
    +   * Options are:
    +   *   - 'freq_desc': descending order by label frequency (most frequent 
label assigned 0)
    +   *   - 'freq_asc': ascending order by label frequency (least frequent 
label assigned 0)
    +   *   - 'alphabet_desc': descending alphabetical order
    +   *   - 'alphabet_asc': ascending alphabetical order
    +   * Default is 'freq_desc'.
    +   *
    +   * @group param
    +   */
    +  @Since("2.2.0")
    +  final val stringOrderType: Param[String] = new Param(this, 
"stringOrderType",
    +    "The method used to order values of input column. " +
    +      s"Supported options: 
${StringIndexer.supportedStringOrderType.mkString(", ")}.",
    +    (value: String) => 
StringIndexer.supportedStringOrderType.contains(value.toLowerCase))
    +
    +  /** @group getParam */
    +  @Since("2.2.0")
    +  def getStringOrderType: String = $(stringOrderType)
    --- End diff --
    
    @viirya Which ML classes were you referring to? I was told not to change 
the raw values in the getters in other PRs  #16675. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to